hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
305 stars 48 forks source link

Make screen sharing dialog more responsive and/or allow resizing #175

Closed devtrends closed 9 months ago

devtrends commented 9 months ago

The screen sharing dialog cuts off text when certain fonts are used:

image

I have tried resizing this with a window rule but it doesn't have any effect:

windowrule = size 600 300, title:MainPicker$
vaxerski commented 9 months ago

There was a MR for that (#173) but the author for some reason got frustrated and closed it. I might remake the thing to be resizeable.

rurigk commented 9 months ago

There was a MR for that (#173) but the author for some reason got frustrated and closed it. I might remake the thing to be resizeable.

Sorry i had a very very bad day, that mr was the product of frustration of not being able to resize and restore the size of the dialog

I think the easy way for the problem to remembering the size its to save it on /tmp and dont worry about any file It will forget the size but just at least it will remember when the user is using the dialog

I will reopen the MR you can use the code if you want i just wanted a better experience for me and share it with others I also apologize for closing the MR

You can cherry pick the size remembering thing if you really dont want the size to be remembered, in that case i will mantain the fork for personal use

vaxerski commented 9 months ago

I believe remembering the size is not really needed as we have windowrules to deal with that. Adding more config files just because we wanna remember the size sounds kinda pointless

rurigk commented 9 months ago

This should be fixed with #173 @devtrends can you give it a try?

devtrends commented 9 months ago

Looks good to me. Window is resizable and respects window rules. It seems to remember last size (unless you force close dialog) Position of Allow a restore token on left is better. Only slight issue is the display of long window names (see 2nd item down) Arguably showing the start and ellipsizing might be better but really not a big deal. Nice job

image

rurigk commented 9 months ago

@devtrends This problem should be solved by #176 can you give it a try?

devtrends commented 9 months ago

@rurigk Perfect. Just tried it and it looks great.

image