hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
306 stars 48 forks source link

core: move to sdbus-cpp2 #278

Closed vaxerski closed 1 month ago

vaxerski commented 1 month ago

Works, needs testing. Screencopy seems to be doin good

@fufexan ci

VirtCode commented 1 month ago

Working fine for me too so far, tested screencopy with OBS and Vesktop. Is there something other than screencopy that would need testing?

vaxerski commented 1 month ago

color picking and global shortcuts, ideally

Agent00Ming commented 1 month ago

Any clients known to use the GlobalShortcuts portal? Screenshots and color picking seem to work fine.

vaxerski commented 1 month ago

not that I know of. I used some random mumble fork back when designing this

VirtCode commented 1 month ago

Can confirm that the Screenshot portal with PickColor is working fine.

I also tested GlobalShortcuts (managed to find one of the rare programs that actually have support for it) and they also work as expected (as far as I can tell). So I think this is good to go.

For future reference, here's how I tested the GlobalShortcuts: I used gpu-screen-recorder-gtk-git but had to patch out an exception for hyprland which was related to an issue which has by now been fixed.

  1. install gpu-screen-recorder-git from the AUR
  2. clone https://repo.dec05eba.com/gpu-screen-recorder-gtk (webpage)
  3. patch out the hyprland exception with the following patch
    
    diff --git a/src/main.cpp b/src/main.cpp
    index b8c0e71..0d9253e 100644
    --- a/src/main.cpp
    +++ b/src/main.cpp
    @@ -4006,7 +4006,7 @@ static void activate(GtkApplication *app, gpointer) {
         // instead of having a "register hotkeys" button. This needed because Hyprland doesn't remember registered hotkeys after
         // the desktop portal is restarted (when the computer is restarted for example).
vaxerski commented 1 month ago

cool, thanks!