search

hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
290 stars 48 forks source link

Change package to consume `sdbus-cpp_2` as argument, remove `sdbuscpp` overlay #286

Open spikespaz opened 3 hours ago

spikespaz commented 3 hours ago

This is an odd name. sdbus-cpp is the name of the package, should the overlay not also have the same name?

Regardless, this overlay should be removed, because sdbus-cpp_2 is in Nixpkgs and sdbus-cpp is not being removed (I assume, since there are two names).

Let's change the XDPH package to take sdbus-cpp_2 instead of destructively modifying the entire pkgs namespace with a new version of sdbus-cpp.

Originally posted by @spikespaz in 5c72a7f

This is a personal TODO, unless @fufexan grabs it.

spikespaz commented 3 hours ago

Ideally, it should have been done like this:

pkgs: pkgs0: {
  xdg-desktop-portal-hyprland = pkgs0.xdg-desktop-portal-hyprland.override {
    sdbus-cpp = pkgs.sdbus-cpp_2;
  };
}

The reason is that the sdbuscpp overlay will change the version of the sdbus-cpp package (as named) to 2.0.0 instead of leaving it alone at 1.5.0 for other packages in Nixpkgs.