search

hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
273 stars 47 forks source link

Upright screens are handled wrong #43

Closed galister closed 1 year ago

galister commented 1 year ago

There are a couple of discrepancies when attempting to cast upright screens with XDPH (and possibly 180 / flipped as well).

On KDE, OBS (PipeWire) on a screen with transform: 1 gives an upright image that's already rotated, with dimensions correct for upright presentation. I would think this is the correct behavior, since screen sharing is one of the primary use-cases for this, where the user can't easily rotate or flip their screen.

On Hyprland with XDPH, OBS (PW) shows an image that's lying flat (not rotated) with parts of the image being black, and other parts missing, seemingly due to a wrong offset. The dimensions are the native dimensions of the screen without any adjustment. Image Link.

Behavior is the same with both memfd and dmabuf capture.

Comparing to wlr_export_dmabuf (wlrobs), with that we get the native image unrotated, but there's no offset issue and the image is perfectly usable after manually rotating inside OBS.

vaxerski commented 1 year ago

closing due to the v1.0 rewrite

gual commented 3 months ago

@vaxerski, this is my issue as well. Do you have any pointers on how to approach this? When sharing, if there is a rotation for a monitor, the shared image does not get rotated. I'm using v1.3.2. Should I create another ticket?

Arnau478 commented 3 months ago

Related: #228