hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
305 stars 48 forks source link

`org.freedesktop.impl.portal.Screenshot`'s `PickColor` does't work as expected #66

Closed zefr0x closed 11 months ago

zefr0x commented 1 year ago

When I request a color using the PickColor method in the org.freedesktop.impl.portal.Screenshot interface, I will see a white semi-transparent layer in my whole screen (like when using the Screenshot method).

Most times I will get a white color #EEEEEE as a response to my request, but sometimes I will get a real color.

After some random tests it seems to behave like this:


I expect it to behave like:

Also a hyprpicker like UI would be a very great thing.

eneoli commented 11 months ago

Hi @zefr0x. In the meantime there were some changes to the Screenshot and PickColor capabilities. Most importantly the portal now uses hyprpicker for picking colors if installed. The problems you describe seem to boil down to grim and slurp. These tools were used to pick colors and are still used as a fallback. Their ui matches exactly your description.

So you might want to try the newest portal version with installed hyprpicker.

zefr0x commented 11 months ago

Thanks for that, it works great now.

Although I would like to see a solution for the Freezes your displays when picking the color issue in hyprpicker. (I'm not sure if it's a problem or not, it might be a feature in some cases)

vaxerski commented 11 months ago

not possible to fix at the moment