hyrise / Cockpit

A Cockpit for Self-Driving Databases.
15 stars 3 forks source link

Adjust workload configuration view #768

Closed Alexander-Dubrawski closed 3 years ago

Alexander-Dubrawski commented 3 years ago

At the moment the workloads are displayed as name SF scale factor. So for example TPC-H SF 1. We should change it to name (SF scale factor ) and change JOB to Join order benchmark.

Alexander-Dubrawski commented 3 years ago

@kathwill if I remember it correctly you implemented the WorkloadGeneration component in the Frontend. I had a look in the code and I'm not sure if there is a fast and clean adjustment to show the workload in the format name (SF scale factor ). Maybe you can give me your Opinion 🙃 . Here is my understanding of the code so far: It seems that inside the component, for every workload a name is generated in the form name SF scale factor and appended to a aviableWorkload list. This string is used in all the underlying components and to get the equivalent frequency and weights inside the Workload generation. Since the frequency and weights for the workload are based on the index of a workload from the aviableWorkload list I'm not sure how to adjust it. I tried to adjust it in a quite hacky way in #772 . Do you have maybe some tips for a better solution? I tried to replace the string logic to communicate the workload with its name by replacing it with an object that has a display_name, scale_factor, and workload_type attributes but after a while I realized that this solution would require quite a big refactoring.