search

hyrise / Cockpit

A Cockpit for Self-Driving Databases.
15 stars 3 forks source link

Adjust workload names #772

Closed Alexander-Dubrawski closed 3 years ago

Alexander-Dubrawski commented 3 years ago

Resolves #768

Does your pull request solve a problem? Please describe:
Before this PR the workload names were displayed as workload SF scale factor. Now they are displayed as workload (SF scale factor). Moreover, the job workload is displayed as Join Order Benchmark.

Additional context:
Sadly for some reason, the component in the frontend that is displaying the workloads communicated a selected workload very strange:

  1. The frontend asked the backend for the available workloads.
  2. It created a string (for example tpch SF 1)
  3. When the user selected a workload the workload display component sends the string (for example tpch SF 1) to the workload component in the frontend.
  4. This component extracted the scale factor and workload name from this string.
  5. The workload component sends the selected workload extracted from the string somewhere in the frontend (Since it is not documented I don't know where)

Since this logic is a big part of the workload selection componet and the frontend is not documented I tried to solve the problem inside the workload component. As a result, we now have some complex regex expressions. Sadly I have no idea how to solve this problem in a clean way without a knowledge of the logic and Idea behind the approach in the frontend.