Add tests for epic algorithm

hyrise / index_selection_evaluation

Platform to evaluate index selection algorithms

MIT License

80 stars 25 forks source link

Add tests for epic algorithm #18

Closed Bensk1 closed 4 years ago

Bensk1 commented 4 years ago

Also some refactoring and bug fixing.

Bensk1 commented 4 years ago

Reminder to myself after merge: use utils.py

Bensk1 commented 4 years ago

Test and implement this:

if new_combination[position] in index_combination:
                    continue

in _attach_to_indexes

Bensk1 commented 4 years ago

Test and implement this:
if new_combination[position] in index_combination:
                    continue
in _attach_to_indexes

Done

Bensk1 commented 4 years ago

Currently, the algorithm fails. I cherry-picked a hot fix from the measurement branch which relies on changes that @klauck made on his MS branch. If we merge the MS branch into master and master into this one, it should work without making everything even more complicated.

Bensk1 commented 4 years ago

Ready for merge from your site?