search

hyrise / index_selection_evaluation

Platform to evaluate index selection algorithms
MIT License
80 stars 25 forks source link

Test and refactor IBM algorithm #24

Closed Bensk1 closed 4 years ago

Bensk1 commented 4 years ago

This does not test everything yet, but I would try to get this into master quickly. I took some notes which tests are missing.

klauck commented 4 years ago

I am almost done with my review/improvements, it's probably ready to merge later today.

Bensk1 commented 4 years ago

Nice, thanks

klauck commented 4 years ago

I am almost done with my review/improvements, it's probably ready to merge later today.

I defer the merge to tomorrow, because I was busy with implementing CoPhy, today.

klauck commented 4 years ago

I am done with my (first) review (round). Merging is ok for me, but I think the code can still be improved, which I skip for priority reasons. @Bensk1 Please, review my bug fixes and changes. @Bensk1 Let us discuss my open subsuming question on Monday.

Bensk1 commented 4 years ago

Looks good to me, which of your changes was a bug fix?

Bensk1 commented 4 years ago

I added the fix to combine_subsumed based on the mail from Daniel Zilio. Is this good to go?

Bensk1 commented 4 years ago

I added the fix to combine_subsumed based on the mail from Daniel Zilio. Is this good to go?

Permission granted on Slack.