search

hyrise / index_selection_evaluation

Platform to evaluate index selection algorithms
MIT License
80 stars 25 forks source link

Question with b_to_mb and mb_to_b #46

Closed earthwuyang closed 2 years ago

earthwuyang commented 2 years ago

Hello, I found that b_to_mb and mb_to_b in selection/utils.py are multiplied or divided by 1000. But I remember people often use 1MB=220 B instead of 106 which is the case of conversion of second and miliseconds. Will this matter?

earthwuyang commented 2 years ago

As for the format, it's 2^20 and 10^6

Bensk1 commented 2 years ago

I cannot think of any case where this should matter. Do you have any specific conversion problem or use case in mind?

We did not see any advantage of the 2^20 definition and this would actually be mebibyte, which are abbreviated as MiB instead of MB.

earthwuyang commented 2 years ago

Thank you! I got it. You are right. I met the problem because MB is differently used in my country. Sorry for bothering!