search

hyrise / sql-parser

SQL Parser for C++. Building C++ object structure from SQL statements.
MIT License
749 stars 243 forks source link

Update Toolchain for ARM Macs and add macOS CI stage #216

Closed dey4ss closed 2 years ago

dey4ss commented 2 years ago

This PR updates the Makefile and the format script to support the different brew library path on ARM Macs. Furthermore, it adds a macOS stage to the CI pipeline.

Bouncner commented 2 years ago

Do you think it makes sense to add a osx worker to travis?

dey4ss commented 2 years ago

I think there's no reason not to do so. I'm gonna have a look at it.

dey4ss commented 2 years ago

@Bouncner after quite some fiddling around, I added a macOS stage. To successfully run the tests, I suppressed memory leak checks when the tests do not run on a Linux machine (valgrind is only available there). Notably, the new CI stage uses Apple's clang rather than the brew version because installing llvm took quite long (up to 10 minutes, whereas the other stages run about 1-2 min). To still get an insight on the used compiler, I print the compiler version in the CI. Furthermore, I updated the current Ubuntu stages to Ubuntu 22.04 with gcc-12/clang-14.