search

hyrise / sql-parser

SQL Parser for C++. Building C++ object structure from SQL statements.
MIT License
749 stars 243 forks source link

Fix CI build for Ubuntu 18.04 #246

Closed dey4ss closed 3 months ago

dey4ss commented 3 months ago

In #245, we noticed that the Github checkout action now uses a Node.js version that is incompatible with our gcc-6/Ubuntu-18.04 stage. Thus, we pull the code manually for this stage.

Bouncner commented 3 months ago

If it is too much of a pain, maybe upgrade to something more recent than GCC 6 and add a note?

Also: if checkout's node is too crappy to work on Ubuntu 18, might it make sense to checkout on our own?

dey4ss commented 3 months ago

Also: if checkout's node is too crappy to work on Ubuntu 18, might it make sense to checkout on our own?

I was afraid that the Github actions required node.js also for some more magical things during the runner image orchestration, but it seems to work just like that