search

hyriver / pygeohydro

A part of HyRiver software stack for accessing hydrology data through web services
https://docs.hyriver.io
Other
68 stars 23 forks source link

Change to epsg:4269 in WaterData request #36

Closed emiliom closed 4 years ago

emiliom commented 4 years ago

It looks like the USGS GeoServer layers were changed in the last 24 hours!! They no longer support epsg:900913 (web mercator), and now only accept epsg:4269. NWIS.get_info now fails because of this. I updated the epsg code on the WaterData call, and that should fix it. I've run WaterData calls with epsg:4269 on other layers (FYI, huc12) and it works.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

emiliom commented 4 years ago

Sorry, I haven't run any of the items on your PR template checklist. We're in the middle of WaterHackWeek. My tutorial went great yesterday, but my notebook today fails b/c of a USGS server change to accepted projections. We can no longer use hydrodata.interactive_map or hydrodata.NWIS. It'd be awesome (and a big ask, I know!) if you could accept this PR AND issue a new conda package build today, so we can roll it into our JupyterHub base conda environment by tomorrow morning.

Thank you in advance! But I understand if you're not able to do this quickly. We all have lots of things going on.

cheginit commented 4 years ago

Thanks for the PR. Yes, I have been working with the WaterData maintainers since the issue that you opened last week and they fixed it today. I have already taken care of all the necessary changes and was planning on releasing a new version for all the packages today. But if you prefer, I can hold off the release and just accept this PR until you finish the workshop?

emiliom commented 4 years ago

Great! I'd prefer non-breaking changes only this week. If your new release doesn't break prior use patterns, I say go ahead with it. Otherwise, a new release or bumped version with just my pr would be safer, maybe?

cheginit commented 4 years ago

There's no breaking change in Hydrodata itself, but there are some breaking changes in PyGeoOGC and PyNHD. If you haven't used those two I can go ahead with my release but if not I will accept your PR.

emiliom commented 4 years ago

In my notebook I use hydrodata, pynhd, pygeoogc and pygeoutils. You can look it up directly to see if your new release would break anything.

A couple of groups are using my notebook directly, adapting the code to their purposes.

cheginit commented 4 years ago

Ok, then. I will go ahead with this PR.

emiliom commented 4 years ago

Thank you! Let me know once you've issued a PR to update the conda package.

We're set up on our end to rebuild the JupyterHub conda environment overnight.

cheginit commented 4 years ago

You're welcome.

I just released v0.7.3b0. It usually takes up to half of an hour until you can install it via conda.

emiliom commented 4 years ago

Wonderful! Thank you so much for being so accommodating. I'll try to test it in about an hour.

FYI, I just pointed my group to py3dep for US DEM data access :wink:

cheginit commented 4 years ago

FYI, I just pointed my group to py3dep for US DEM data access.

Thanks! Unfortunately, National Map's 3DEP has been down since last week! I have contacted them but haven't heard from them yet. https://elevation.nationalmap.gov/arcgis/services/3DEPElevation/ImageServer/WMSServer?request=GetCapabilities&service=WMS

emiliom commented 4 years ago

The conda package is ready, and I've confirmed (after rebuilding my conda env locally) that everything works again! Thanks so much.

I'm looking forward to your tutorial tomorrow.

cheginit commented 4 years ago

Glad to hear that. See you tomorrow!