hysds / hysds-framework

HySDS framework releases
Apache License 2.0
4 stars 7 forks source link

HC-522: Future proof being able to pin setuptools when needed #32

Closed mcayanan closed 2 months ago

mcayanan commented 2 months ago

With the setuptools 70.0 release, it is found that it broke our builds due to the issue described here:

https://github.com/pypa/setuptools/issues/4399

Prior to this being fixed, the temporary resolution was to pin setuptools to less than 70.0 until this issue is fixed. Just a heads up, there is a related PR that contains the above-mentioned fix: https://github.com/pypa/setuptools/pull/4422

Therefore, since this pin is no longer needed, we should still put comments in the event that we need to revisit pinning setuptools in the future. Therefore, the following was added to the install.sh:

mcayanan commented 2 months ago

Need to remove kludges in the circleci.yaml

mcayanan commented 2 months ago

@pymonger kludges have been removed