hysts / pytorch_mpiigaze

An unofficial PyTorch implementation of MPIIGaze and MPIIFaceGaze
MIT License
346 stars 86 forks source link

Evaluation Ambiguity #4

Closed ld909 closed 4 years ago

ld909 commented 5 years ago

Hi there, we run your code but found the evaluation method you implemented might be ambiguous. As code shows, you used the last epoch to make evaluation for the one witch is left out during training. There seems no model selection process so if we change the number of epochs, this might lead to another cross-person evaluation results

hysts commented 5 years ago

Hi, that's right. It's better idea to hold out some data for validation other than test data.

hysts commented 4 years ago

I fixed this problem long ago, but it seems I forgot to close it...