Mission fail with new companion Elwyn

hythloday / VenturePlanSoDMissions

Addon to bring VenturePlan up to date with the 9.1 missions

GNU General Public License v3.0

134 stars 36 forks source link

Mission fail with new companion Elwyn #34

Closed woefulwabbit closed 3 years ago

woefulwabbit commented 3 years ago

Logs attached: elwyn.log

Version is different, but the values for spell 306 match: [306]={type="aura", target=3, duration=3, modMaxHP=60, plusDamageDealtATK=40}, --Arcane Empowerment (UNVERIFIED)

boomboo commented 3 years ago

I don't know if it caused the failure but modMaxHP is wrong and should be modMaxHPATK

BradCOnGitHub commented 3 years ago

Found it. There's a hard coded 20 follower limit in Widgets.lua on line 1960. I'm not sure if you can fix that from another addon.

FlipperPA commented 3 years ago

@BradCOnGitHub I wish I'd read your comment first, I went hunting through the code myself... and just PR'd a change to the README!

cremor commented 3 years ago

@BradCOnGitHub and @FlipperPA Are you sure that fixing the 20 follower limit in Widgets.lua actually fixes this mission fail? Isn't that only a fix for the follow list display?

BradCOnGitHub commented 3 years ago

The other fix is needed too, but it doesn't cause a lua error. It was just using a percentage based HP buff instead of a fixed amount, which was wrong.

We probably hijacked the orginal issue here.