search

hyunsupul / aesop-core

Open-sourced suite of components that empower interactive storytelling in WordPress.
http://aesopstoryengine.com
GNU General Public License v2.0
245 stars 56 forks source link

Quote component change #200

Closed peiche closed 9 years ago

peiche commented 9 years ago

Default cite text gets inserted into the post markup if no cite property is defined in the shortcode. This change defaults the tag to be hidden unless explicitly defined. (Due to my ineptitude, this PR contains changes for generator.js files... that's not intentional. The only change I want to draw your attention to is in component-quote.php.)

michaelbeil commented 9 years ago

this has already been fixed here https://github.com/bearded-avenger/aesop-core/commit/4d1cbc5c504239683fb1d750d6ac6293041c65a4.

thanks @peiche!

peiche commented 9 years ago

I totally did not see that. Sorry!