hyunsupul / aesop-core

Open-sourced suite of components that empower interactive storytelling in WordPress.
http://aesopstoryengine.com
GNU General Public License v2.0
245 stars 56 forks source link

"Labels" for custom components #351

Closed AlchemyUnited closed 5 years ago

AlchemyUnited commented 5 years ago

Hey Hyun - I had created a custom component (which I will share with you soon) and noticed that the "fancy shortcode" (I'm not using GutenB) didn't have any sort of identifier. That is, there was no way of knowing what it was / is exactly, the only thing rendered was the component name / type.

After some digging around I noticed that those things were hardcoded in plugin.js. So I made some simple changes to make plugin.js a bit more flexible. I also introduced the possibility of having a (text_area) field {component} . '_internal_note' that would allow the user to specify the "label" they see in TinyMCE, instead of what ASE assumes. Perhaps also, there will be a use for an admin only side field with GutenB?

p.s. I did a fetch from your origin / master repo before I did this update, so I'm not sure why my branch / PR can't auto merge. If you know why, please let me know so I don't do it again.

tia