search

hyunsupul / aesop-core

Open-sourced suite of components that empower interactive storytelling in WordPress.
http://aesopstoryengine.com
GNU General Public License v2.0
245 stars 56 forks source link

add iframe size options to video block #356

Closed cherbst closed 5 years ago

hyunsupul commented 5 years ago

Hi, thank you for your contributions. I just have a question. Any reason you removed the calls to esc_attr()?

cherbst commented 5 years ago

Yes, $iframe-size already contained the html attributes. The call to esc_attr() added double quotation marks, so it ended up with to something like width=""300"" height=""150"".