search

hyunsupul / aesop-core

Open-sourced suite of components that empower interactive storytelling in WordPress.
http://aesopstoryengine.com
GNU General Public License v2.0
245 stars 56 forks source link

Gallery component creates empty error message in backend #358

Closed cherbst closed 5 years ago

cherbst commented 5 years ago

Lines 525-538 in file component-gallery.php create an empty error notice in the backend. It is not really clear what this is about and is confusing for users.

AlchemyUnited commented 5 years ago

@cherbst - To be clear, it's not a PHP error, but a message / alert generated by Aesop, yes? And that you believe the message is ambiguous at best, and should be more helpful? Is that it?

p.s. Thanks for the heads up.

AlchemyUnited commented 5 years ago

@hyunsupul - Perhaps this is something to generate on install? Or sooner (i.e., outside the actual component) in the process? I believe it might be possible to filter the components list and more the galleries. That is, let the plugin run, but effective remove anything that's not going to work well. Maybe/

cherbst commented 5 years ago

@AlchemyUnited - Yes, this is a notice generated by Aesop. And as the message is empty (there is nothing shown in the notice), yes it could be more helpful.

hyunsupul commented 5 years ago

This seems to be from way back when the gallery format changed many years ago. I think it's safe to remove this notice by now so I did.