search

hyunsupul / aesop-core

Open-sourced suite of components that empower interactive storytelling in WordPress.
http://aesopstoryengine.com
GNU General Public License v2.0
243 stars 56 forks source link

fix type of video block attributes #360

Closed cherbst closed 5 years ago

cherbst commented 5 years ago

the shortcode expects these attributes to be strings, not booleans. Without the fix, the values of attributes which were default 'on' in the shortcode (e.g. autoplay) could not be switched of after they were once changed because the default in the shortcode overrides the value from the block which was not set. Using 'string' as the type, if switched off, the option in the shortcode is set und thus the default is not applied.

hyunsupul commented 5 years ago

Hi can you tell me if this would not affect any users who used the previous version to compose posts? Thanks.