hyunsupul / aesop-core

Open-sourced suite of components that empower interactive storytelling in WordPress.
http://aesopstoryengine.com
GNU General Public License v2.0
244 stars 56 forks source link

1.1 - text content needs line break #88

Closed bearded-avenger closed 10 years ago

bearded-avenger commented 10 years ago

When flipping between text and visual mode, it doesn't respect the line break. This leads to wpautop not firing on the front end.

http://g.recordit.co/BjYulZoTOC.gif

here's what that does to front end http://cl.ly/image/1h0g1k3n1N2n

then when fixed, or not butted up against the end http://cl.ly/image/3P2z2b341G0g

etcook commented 10 years ago

@bearded-avenger I'm on this right now.

etcook commented 10 years ago

@bearded-avenger What are the screenshots images of? Is that the source of the editor? Is that the source of the rendered page? Please include the entire screen, including url, etc when posting screenshots to properly communicate scope.

bearded-avenger commented 10 years ago

the gif includes 80% of the screen. the post screen. you can tell when toggling between visual and text modes what's happening just by watching the gif.

here's what's happening, in text view

[aesop_shortcode]Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritati

this is what needs to happen, and is how wp currently handles theirs

[aesop_shortcode]

Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritati
etcook commented 10 years ago

Fixed - b085020691fa881f83587cae06767f669a662e99

bearded-avenger commented 10 years ago

yeah confirmed this fix