hyunsupul / aesop-core

Open-sourced suite of components that empower interactive storytelling in WordPress.
http://aesopstoryengine.com
GNU General Public License v2.0
244 stars 56 forks source link

Chapter component: non-Aesop themes lose bg image height #98

Closed simplemama closed 10 years ago

simplemama commented 10 years ago

When using a non Aesop theme (and have added the theme support PHP snippet), chapter background images lose the height value.

Example when working correctly, in an Aesop theme:

<div class="aesop-article-chapter clearfix " style="height: 903px; background: url(http://playground.aesopstories.com/wp-content/uploads/sites/2/2013/12/Hana-Bamboo-Maui-Hawaii.jpg) 50% 50% / cover;">

Example when not working, in any other theme:

<div class="aesop-article-chapter clearfix " style="background:url('http://playground.aesopstories.com/wp-content/uploads/sites/2/2013/12/Hana-Bamboo-Maui-Hawaii.jpg');background-size:cover;background-position:center center;">
bearded-avenger commented 10 years ago

ok fixed and improved

https://github.com/bearded-avenger/aesop-core/commit/5296352e575e4b9455548ca088837a92e25c71cd

pictured in Genesis here http://cl.ly/image/2b271e2S0g26

Note: extended theme support must be active with at least support for chapter styles

add_theme_support("aesop-component-styles", array( "chapter" ) );