search

hyva-themes / magento2-hyva-admin

This module aims to make creating grids and forms in the Magento 2 adminhtml area joyful and fast.
https://hyva-themes.github.io/magento2-hyva-admin/
BSD 3-Clause "New" or "Revised" License
168 stars 39 forks source link

#21 Add link to first/last page to navigation #23

Closed Bartlomiejsz closed 3 years ago

Bartlomiejsz commented 3 years ago

Hi @Vinai, this is awesome replacement for native grids, let's see if I can help here a bit :)

Vinai commented 3 years ago

Thank you very much, awesome 👍 The unit tests fail because the MAGENTO_MARKETPLACE_USERNAME and MAGENTO_MARKETPLACE_PASSWORD are not set as a repo secret.

I've checked out the branch locally, it looks good and all tests pass.

Bartlomiejsz commented 3 years ago

That's weird @Vinai, once those failed first time I did set up both secrets on my fork: image and it still failed

However, thanks for quick action :)

Vinai commented 3 years ago

Strange indeed. I'm using actions based on https://github.com/extdn/github-actions-m2. The integration build works without the credentials, it's only the unit tests that require them. I want to update the action so it doesn't require those settings either... it's annoying if they don't work for PRs-

Vinai commented 3 years ago

I've added a custom docker entrypoint that uses the repo-magento-mirror.fooman.co.nz mirror repo and removed the need for the secrets. Thanks @fooman a.k.a. Christof you are such a treasure! :)