search

hyva-themes / magento2-hyva-admin

This module aims to make creating grids and forms in the Magento 2 adminhtml area joyful and fast.
https://hyva-themes.github.io/magento2-hyva-admin/
BSD 3-Clause "New" or "Revised" License
168 stars 39 forks source link

Feature/export #38

Closed pointia closed 3 years ago

pointia commented 3 years ago

Added ability to export files to csv or excel xml

Vinai commented 3 years ago

Thanks for the PR! Looking at the commits, it seems it still is based on the php73 branch (see the commit 1650ffe at the beginning of the list. Is that correct? Maybe you can rebase your branch onto the current HEAD or the main branch? That would make it easier to see your changes.

pointia commented 3 years ago

@Vinai you are right. Now it should look better. Please be so kind and have another look.

Vinai commented 3 years ago

Thanks @pointia - starting review now.

pointia commented 3 years ago

@Vinai Danke für deine Anmerkungen. Ich habe soweit alles (außer ich hab was übersehen) eingearbeitet.

Vinai commented 3 years ago

Hey, I'll switch to English again, simply out of habit. Hope that's okay for you. I've backported the main branch to PHP 7.3 because of issues with rector. If you work in the conflicts above and get the tests to pass I'll happily merge the PR - thanks again for all your work.

Vinai commented 3 years ago

Thank you for the updates! I'll see I'll get it merged in a day or two!

Vinai commented 3 years ago

Thanks again for all your work on this @pointia!