Magento 2.3.x and below doesn't support anonymous classes

hyva-themes / magento2-hyva-admin

This module aims to make creating grids and forms in the Magento 2 adminhtml area joyful and fast.

https://hyva-themes.github.io/magento2-hyva-admin/

BSD 3-Clause "New" or "Revised" License

168 stars 39 forks source link

Magento 2.3.x and below doesn't support anonymous classes #47

Open indefinitedevil opened 3 years ago

indefinitedevil commented 3 years ago

Fixed in https://github.com/magento/magento2/commit/e165d99f5994af39d49ed70155c003745158e5db#diff-eac375a5ebf2447976201de8fbe0bd0d04ce9798bc0e49c573e8d755317dac22

Basically, as it stands, the DI compiler for versions below 2.4.0-p1 doesn't support anonymous classes and so any compilation which uses Hyva Admin will fail due to the anonymous classes used in the factory models.

Vinai commented 3 years ago

Thanks for bringing this up, @indefinitedevil I'd be willing to merge a PR that extracts all anonymous classes into named classes, but at the moment I don't have time to do it myself at the moment. My first priority in my open source time is to get admin forms support working. After that I would circle around to this issue if no one has beaten me to it by then.