Closed Vinai closed 3 years ago
Currently integration and unit tests are separate workflows. Reminder to self: check if combining integration and unit tests as separate jobs in a single workflow is better. Confirmed: combined is nicer.
Can't install rector or rector-prefixed in Magento due to deps hell and can't use rector docker because I want it to run in an unprivileged docker github action. Don't want to spend the time to build a custom image and action.
Going to have to backport and test locally.
Probably github actions Need to run unit and integration tests on PHP 7.4 and PHP 7.3 for each branch/PR.
~Need to clean up integration tests first so they don't require sample data to be installed.~