hyva-themes / magento2-hyva-admin

This module aims to make creating grids and forms in the Magento 2 adminhtml area joyful and fast.
https://hyva-themes.github.io/magento2-hyva-admin/
BSD 3-Clause "New" or "Revised" License
168 stars 39 forks source link

Illegal byte sequence during composer install, probably due to "hyvä" being used in filename #50

Closed hostep closed 3 years ago

hostep commented 3 years ago

Hi!

I just noticed when upgrading hyva-themes/module-magento2-admin from 1.1.5 to 1.1.14 the following output in the composer installation output:

Package operations: 1 install, 0 updates, 0 removals
  - Installing hyva-themes/module-magento2-admin (1.1.14): Extracting archive
    Failed to extract hyva-themes/module-magento2-admin: (50) unzip -qq  'vendor/composer/tmp-bd4f096c2473d75e60620b636d854730' -d 'vendor/composer/d405b1b4'

error:  cannot create vendor/composer/d405b1b4/hyva-themes-magento2-hyva-admin-9262d82/doc/1. Overview/5. Deep Docs/60. Hyv+� Admin Forms (WIP).md
        Illegal byte sequence

    The archive may contain identical file names with different capitalization (which fails on case insensitive filesystems)
    Unzip with unzip command failed, falling back to ZipArchive class

Seems to be that composer can't handle the Hyvä filename of that markdown file on my system.

More environmental info:

It would probably be good to rename that file and change ä to a to avoid this problem?

Vinai commented 3 years ago

Thanks, will do!

Vinai commented 3 years ago

Fixed in release 1.1.15

hostep commented 3 years ago

Nice, I can confirm that it doesn't happen anymore on version 1.1.15

Thanks for the super fast change!