search

hyva-themes / magento2-hyva-admin

This module aims to make creating grids and forms in the Magento 2 adminhtml area joyful and fast.
https://hyva-themes.github.io/magento2-hyva-admin/
BSD 3-Clause "New" or "Revised" License
168 stars 39 forks source link

Format addressDataType if no firstname or lastname set #57

Closed mattgrul closed 3 years ago

mattgrul commented 3 years ago

Format CustomerAddressDataType.php to remove space and comma if no firstname or lastname are set.

Before Screenshot from 2021-07-01 16-33-26

After Screenshot from 2021-07-01 16-32-45

Vinai commented 3 years ago

Thanks! Once the actions are through I'll happily merge!

mattgrul commented 3 years ago

Thanks Vinai!

Vinai commented 3 years ago

I've checked locally that the broken integration tests are resolved after rebasing on main, so I'll go ahead and merge.

Thanks again for contributing

mattgrul commented 3 years ago

Amazing, no problem!