Translate grid labels - Githubissues

hyva-themes / magento2-hyva-admin

This module aims to make creating grids and forms in the Magento 2 adminhtml area joyful and fast.

https://hyva-themes.github.io/magento2-hyva-admin/

BSD 3-Clause "New" or "Revised" License

168 stars 39 forks source link

Translate grid labels #63

Closed FredericMartinez closed 2 years ago

FredericMartinez commented 2 years ago

templates/grid.phtml has a lack of translate function __().

This commit translates:

grid column labels
filter labels
mass action labels

woutersamaey commented 2 years ago

Not sure if this is best practise.

Vinai commented 2 years ago

Thank you for the PR and sorry for keeping it open for so long @FredericMartinez !

The only thing I’m not fully on board with in regards to the PR is the <?= __($cell->getHtml()) ?> The cell content should already be translated if it needs to be.