search

hyva-themes / magento2-hyva-admin

This module aims to make creating grids and forms in the Magento 2 adminhtml area joyful and fast.
https://hyva-themes.github.io/magento2-hyva-admin/
BSD 3-Clause "New" or "Revised" License
168 stars 39 forks source link

DOMDocument::loadXML() expects parameter 1 to be string, object given #8

Closed VincentMarmiesse closed 3 years ago

VincentMarmiesse commented 3 years ago

Hi,

It seems there is an issue in the mergeFile function of the GridConfigReader class.

The merge function of XmlDom $merged requires a string and but you're calling it with a XmlDom as parameter.

Am I missing something here? It should be $merged->merge($content); or something like that imo.

Currently, I have the following error in my logs:

main.CRITICAL: Warning: DOMDocument::loadXML() expects parameter 1 to be string, object given in /var/www/html/vendor/magento/framework/Config/Dom.php on line 456 [] []

Thank you for your work!

Vinai commented 3 years ago

Thanks for your report! What Magento and PHP versions are you using?

VincentMarmiesse commented 3 years ago

Hi, I am using Magento 2.4.1 and PHP 7.4.11.

Vinai commented 3 years ago

Just pushed release 1.0.3 that fixes the issue. Thanks again!