search

hyva-themes / magento2-react-checkout

Highly Customizable Checkout for Magento 2, Built with React.
BSD 3-Clause "New" or "Revised" License
179 stars 53 forks source link

storybook leftovers? #179

Closed DanielRuf closed 3 years ago

DanielRuf commented 3 years ago

It seems there is no dependency storybook in package.json but there are commands to start storybook.

https://github.com/hyva-themes/magento2-hyva-checkout/blob/main/src/reactapp/package.json#L38

The following commit removed storybook but it was probably overseen that there are still storybook commands as scripts in package.json:

https://github.com/hyva-themes/magento2-hyva-checkout/commit/6320c49ef6b79320d180c1af43ed116f7163e7d6#diff-c9fbe45db4b426bcbfa0b209c78e49d625b109e2c473263f232fd756dde5fe77

But the commit message does not mention this.

https://github.com/hyva-themes/magento2-hyva-checkout/commit/29f2f2dbaf77465380db3c73212b41f334aac3db

Checking with git bisect this weas the commit which removed storybook again:

grafik

https://github.com/hyva-themes/magento2-hyva-checkout/commit/e17d9aba09e5617434f58f47fea8336cca2dc283

rajeev-k-tomy commented 3 years ago

Thank you for reporting this @DanielRuf . The storybook was part of the project initially and it is removed because it becomes a bottleneck when it comes to updating the latest react packages. Storybook is one of the least used features in the app. So I decided to remove it.

I forgot to remove that command though. Should be corrected.

rajeev-k-tomy commented 3 years ago

This is now corrected in 1.0.0-rc and soon will be available in the stable release following.