#68 Luma theme improvements

hyva-themes / magento2-react-checkout

Highly Customizable Checkout for Magento 2, Built with React.

BSD 3-Clause "New" or "Revised" License

178 stars 53 forks source link

#68 Luma theme improvements #342

Closed rajeev-k-tomy closed 1 year ago

rajeev-k-tomy commented 1 year ago

This is focusing on many improvements in the luma theme

It removes styles of luma theme completely so that react checkout style will take effect completely and the UI look much more better there.
Completely removing requirejs. This will help to avoid unncessary loading of many luma related javascript files.
Removing many layout blocks which defines requirejs uicomponent initialization and unwanted blocks in the checkout.

rajeev-k-tomy commented 1 year ago

If we are not altering the copyright.phtml file, then we will see an unstyled copyright template in the luma theme. Another option would be remove copyright template from luma theme as well. But, if we cross verify this with luma checkout, we can see that copyright is present at the bottom. So I thought to make it same in the case of react checkout as well.

What do you think @wigman ?

wigman commented 1 year ago

:) misunderstanding. I mean the Magento copyright in the phtml files:

/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

rajeev-k-tomy commented 1 year ago

lol... makes sense now :)