search

hyvart / Unjammit

Multi-platform JCF player.
Other
5 stars 4 forks source link

Import zip files that are not a folder compressed #27

Closed xportation closed 3 years ago

xportation commented 4 years ago

Inside the zip are only files and do not have the JCL folder.

JunielKatarn commented 4 years ago

Hi, @xportation. Thanks for looking into this.

I’ll review this request today.

xportation commented 4 years ago

Sure! This feature will help me a lot. Thanks 👍🏻👍🏻

On 4 May 2020, at 10:12, Julio César Rocha notifications@github.com wrote:

Hi, Leonardo. Thanks for looking into this.

I’ll review this request today.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hyvart/Unjammit/pull/27#issuecomment-623455267, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBVJRZCCCTFCZ6LZ7UEBKDRP25M3ANCNFSM4MYKBBZQ.

xportation commented 4 years ago

I have files without a folder inside. When I import in your app and I get the error: 'Could not process file'. How I didn't find the spec of this file format to understand if the files are good, I proposed this PR.

On 5 May 2020, at 07:49, Julio César Rocha notifications@github.com wrote:

@JunielKatarn commented on this pull request.

@xportation https://github.com/xportation can you please clarify the purpose of this PR? Are you using modified JCF archives? What is the layout within your ZIP file that doesn't work with the current code?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hyvart/Unjammit/pull/27#pullrequestreview-405677600, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBVJR6B7ZNGLCONHF4WNVTRP7VNDANCNFSM4MYKBBZQ.

JunielKatarn commented 4 years ago

I have files without a folder inside. When I import in your app and I get the error: 'Could not process file'. How I didn't find the spec of this file format to understand if the files are good, I proposed this PR. … On 5 May 2020, at 07:49, Julio César Rocha @.***> wrote: @JunielKatarn commented on this pull request. @xportation https://github.com/xportation can you please clarify the purpose of this PR? Are you using modified JCF archives? What is the layout within your ZIP file that doesn't work with the current code? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBVJR6B7ZNGLCONHF4WNVTRP7VNDANCNFSM4MYKBBZQ.

I understand, but your change seems to be modifying structure of the extracted content (i.e. adding that __temp suffix). I would expect your change to:

  1. Determine if the content is inside a {GUID}.jcf/ folder.
  2. Determine if the content is in the root of the ZIP file. If it's the second, then still generate the {GUID}.jcf/ directory in the tracks content folder.

If I'm misinterpreting your code, please reply with a concret example of the folder structure in the app's data directory, including temporary files.