search

hyxnnii / pe

0 stars 0 forks source link

Adding duplicate person is allowed #4

Open hyxnnii opened 2 weeks ago

hyxnnii commented 2 weeks ago

Screenshot 2024-11-15 at 4.22.52 PM.png

How to reproduce: add n/Amy Lee p/333 e/a@gmail.com r/brUdder m/cs a/a add n/amy lee p/333 e/a@gmail.com r/brUdder m/cs a/a Expected: New person should not be added since it is a duplicate. Actual: New person is added even though both persons have the same details. Name should be case insensitive.

nus-se-script commented 2 weeks ago

Team's Response

Thank you for pointing out this issue! We understand that this is a real issue and we recognised this under Appendix: Planned Enhancements in our Developer Guide as shown below. As such we will have to reject this bug since it was already emphasised in our appendix of the DG.

Screenshot 2024-11-18 at 4.09.54 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your response! I have read the planned enhancements in the DG. However, I feel that case insensitivity of name is a separate issue from duplicate handling mentioned in your screenshot, which talks about taking into account different fields other than just names in determining whether two persons are a duplicate. I believe there was no specific mention of the case sensitivity of names under the planned enhancements and so I believe that this issue is valid.