hyyan / woo-poly-integration

Looking for maintainers! - Wordpress WooCommerce Polylang Integration
https://wordpress.org/plugins-wp/woo-poly-integration/
MIT License
183 stars 66 forks source link

Stop Woocommerce Version Check #161

Closed hyyan closed 7 years ago

hyyan commented 7 years ago

The plugin must not check for major woocomerce versions . The code must be light as much as possible After all we do not expect woopoly 1.0.0 to work with woocomerce 2.6 , it is a major update.

Versions check must be for minor changes only in woocommerce and polylang

Jon007 commented 7 years ago

Tricky decision:

Ideally the first woo3 release should be compatible with both woocommerce 2.6 and woocommerce 3.0 for the convenience of users during their transition period, though it's certainly adding complexity to the code and testing. As a user myself, my production is up to date with all components except wooCommerce3 and I would be annoyed if the plugins started releasing woo3 only versions.

Should v1 refuse to activate if wooCommerce >3.0 is not detected?

At the moment:

hyyan commented 7 years ago

@Jon007 I got your Idea, The last version which supports woo v2.6 will be woopoly v0.29 , the new version must support woo v3.0 only with no support for the old version, and I think this way makes sense. and it is easier to test. if we need to support users who use woo2.6 or fix some old bugs we can still patch the version 0.29 , these patch versions will be available throw WordPress repo too then users can switch to old version of this plugin using wp-rollback

WooPoly 1.0.0 and later versions will handle this type of checks clearly upon activationt, I am already working on a solution for this. for now we must stop the check for Woo3.0 in our new code. we check only for minor changes in Woo3.0 and Polylang 2.0

Jon007 commented 7 years ago

ok, understood, let's keep a separate branch for 0.29 patches. Actually there are some in my previous RC which apply to 0.29, but really we need to focus limited available time on moving forward.

Noting WooCommerce 3.0.7 now out, should update the minimum version: there is no point supporting 3.0.1-3.0.6, only the latest version.