Quick edit Product synchronisation issues - Githubissues

hyyan / woo-poly-integration

Looking for maintainers! - Wordpress WooCommerce Polylang Integration

https://wordpress.org/plugins-wp/woo-poly-integration/

MIT License

183 stars 66 forks source link

Quick edit Product synchronisation issues #549

Closed Jon007 closed 3 years ago

Jon007 commented 3 years ago

Can you reproduce this issue on default Wordpress theme (eg Storefront)?

yes

Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?

yes

What product versions and settings are you using when this issue occurs?

PHP: 7.3/7.4
WordPress: 5.7.1
WooCommerce: 5.2.2
Polylang: [state if using Polylang PRO] 3.0.4
Hyyan WooCommerce Polylang Integration: 1.5.1
Browser: any

Steps to Reproduce

ensure site is fully setup and working normally for product translation from product edit screen
go to Products Admin listing eg: /wp-admin/edit.php?post_type=product
hover over a simple product, choose Quick Edit, change attributes and update

What I Expected

translations should be updated with updated properties

What Happened Instead

no synchronisation

Jon007 commented 3 years ago

root cause is that the meta filter is only added within saveQuickEdit on the woocommerce_product_quick_edit_save hook This is the correct hook for the WooCommerce quick edit save completion, however when this executes the Polylang meta synchronisation has already happened (without being filtered to add on the extra WooCommerce properties) and does not reoccur.