hzamani / active_record-acts_as

Simulate multi-table inheritance for activerecord models
MIT License
252 stars 86 forks source link

Add experimental Rails / ActiveRecord 5.0 #63

Closed jaguirresza closed 8 years ago

jaguirresza commented 8 years ago

Add scoped experimental support to activerecord 5.0.0.beta1. So does not add any modifications if it's used activerecord ~>4. This can close #57 for now. Also, add a new version to test in Travis to prove that the support activerecord 5.0.0.beta1.

hzamani commented 8 years ago

Thanks. But is thinks it's better to have different branches for each active-record major version, i.e. matching major version with active-record.

yjukaku commented 8 years ago

@hzamani Do you just want to update the gemspec file then? What version are you thinking of? 2.0.0 or 5.0.0 (to match ActiveRecord version)?

hzamani commented 8 years ago

I am a little busy these days. This will be merged with some modification some time in the next week, following rails versioning.

shaneog commented 8 years ago

Since Rails 5 is now released, do you think that you might have some time (no pressure) to look at this @hzamani ? Thanks!

manuelmeurer commented 8 years ago

Implemented in #80