search

hzamani / active_record-acts_as

Simulate multi-table inheritance for activerecord models
MIT License
252 stars 86 forks source link

Few fixes to touch #78

Closed allenwq closed 8 years ago

allenwq commented 8 years ago
  1. provided an option to specify touch: false: In our case we have a topic super model, and we have something like acts_as :topic, but we only want topic to be touched when posts under topic are changed, not when the acts as model changed. Think it would be useful to skip touch.
  2. Fixed an issue that super model is touched on every save on child, even child is not changed
allenwq commented 8 years ago

@hzamani Travis failed because some gems cannot be installed in 1.9.3...

allenwq commented 8 years ago

@hzamani Let me know your comments, thanks !

manuelmeurer commented 8 years ago

@hzamani I think support for Ruby 1.9.3 can be dropped, it has been EOL for 1.5 years now. What do you think?

allenwq commented 8 years ago

@hzamani Any comments ?

allenwq commented 8 years ago

@hzamani Let me know if you got time to look at this, thanks !

manuelmeurer commented 8 years ago

@allenwq Could you add a quick mention of the touch option to the README, and rebase against thr current master? Then we can get this merged in! 😄

allenwq commented 8 years ago

@manuelmeurer Thank you ! Sorry was on leave during the past weeks. Just rebased and updated the README.