search

hzamani / active_record-acts_as

Simulate multi-table inheritance for activerecord models
MIT License
252 stars 86 forks source link

Upgrade to Rails 5 #79

Closed nicklandgrebe closed 8 years ago

nicklandgrebe commented 8 years ago

Changed implementations of alias_method_chain to use Module.prepend instead, which according to this is how it's done now.

The specs for Ruby versions less than < 2.2.2 fail, but Rails 5 requires Ruby 2.2.2 or newer.

manuelmeurer commented 8 years ago

Awesome stuff! 👍 💯 This should work with Rails 4 as well, right? Shall we add Appraisal to test both?

nicklandgrebe commented 8 years ago

Seems like it'd be very useful! I rolled back the gemspec to include >= 4 instead of my mistake of requiring 5.

Since the two changes I made were Ruby/logic related instead of Rails based, I'm guessing there is backward compatibility. Appraisal would confirm that for sure.