search

hzambran / hydroTSM

Time Series Management and Analysis for Hydrological Modelling
https://CRAN.R-project.org/package=hydroTSM
44 stars 13 forks source link

Vulnerability to absence of retiring r-spatial packages #19

Closed rsbivand closed 8 months ago

rsbivand commented 1 year ago

00check.log is a recent check log from running under _SP_EVOLUTION_STATUS_=2 without retiring r-spatial packages on the library path. hydroTSM depends strongly on maptools to use maptools::readShapePoly, which is has been deprecated for years. Both gstat and automap depend strongly on sf, so there is no reason in terms of load image to avoid sf. If you wish to stay with sp objects, read with sf and coerce to sp.

rsbivand commented 1 year ago

Please also see https://r-spatial.org/r/2023/04/10/evolution3.html, fix best by June, latest October 2023.

rsbivand commented 1 year ago

@hzambran See also https://r-spatial.org/r/2023/05/15/evolution4.html. Please take urgent steps to resolve this issue. No positive changes appear in the repository. Less than three months remain to retain this package on CRAN. See also https://github.com/hzambran/hydroTSM/issues/21 which duplicates this. If you care to read https://r-spatial.org/r/2023/05/15/evolution4.html or https://r-spatial.org/r/2023/04/10/evolution3.html, you'll see how to resolve the maptools dependency (as(sf::st_read(), "Spatial")).

rsbivand commented 1 year ago

@hzambran From hydroTSM_0.6-25.tar.gz, I get: 00check.log with:

* checking data for non-ASCII characters ... WARNING
  Error loading dataset 'EbroCatchmentsCHE':
   Error in .requirePackage(package) : unable to find required package 'sp'

  Error loading dataset 'EbroDEM1000m':
   Error in .requirePackage(package) : unable to find required package 'sp'

  The dataset(s) may use package(s) not declared in Depends/Imports.

Adding sp to Suggests: in DESCRIPTION, needed because S4 classes are defined in sp gives this check log: 00check.log

rsbivand commented 1 year ago

@hzambran Less than three weeks remain to fix this.

rsbivand commented 12 months ago

@hzambran R spatial infrastructure packages maptools, rgdal and rgeos will be archived by CRAN on Monday, October 16, 2023. Your package does not pass CMD check when these packages are not available. Expect your package to be archived by CRAN October 17-18 as CRAN checks feed through and your package fails, if not updated by Monday, October 16, 2023.

No grace period is anticipated, as you have had sufficient time to update your package to remove dependencies on maptools, rgdal and/or rgeos.

hzambran commented 8 months ago

Dear Roger,

I really apologise for not having addressed this warning before, even with the large time in advance used for launching the warning.

hydroTSM is finally back on CRAN: https://cran.r-project.org/package=hydroTSM.

Thank you very much for your messages and patience.