search

hzdg / gsap-react-plugin

A GSAP plugin for tweening React.js component state.
Other
130 stars 8 forks source link

Change filename to match module name #2

Closed matthewwithanm closed 10 years ago

matthewwithanm commented 10 years ago

This is just a small PR to make the filename match the module name ("gsap-react-plugin"), which I think is the convention with single-purpose modules like this.

If you merge this, you can close #1 as it addresses that issue.

lettertwo commented 10 years ago

I thought about this, but ended up going with the naming convention that GSAP uses for its plugins. I'm more than willing to merge this in, though, if you think it makes more sense to match the module name than to match the plugin naming convention. I guess another option might be to rename the module?

matthewwithanm commented 10 years ago

GSAP's modules seem weird to me (some of them are modules, others are more like builds) and not in keeping with the JS community at large. Plus using "ReactPlugin" in a script tag isn't nearly as descriptive as "gsap-react-plugin." Your call though.