search

hzeller / beagleg

G-code interpreter and stepmotor controller for crazy fast coordinated moves of up to 8 steppers. Uses the Programmable Realtime Unit (PRU) of the Beaglebone.
http://beagleg.org/
GNU General Public License v3.0
122 stars 50 forks source link

Accel speed clamping #10

Closed lromor closed 8 years ago

lromor commented 8 years ago

Added clamping function for both speeds and accelerations limits.

Notes:

  1. I think that the user should be notified via socket or logs that because of the settings the speed is impossible to reach so the max has been set.
  2. The feedrate should always represent a speed during an euclidean displacement. What happens if we just use the extruder and all the other axis are in stop? The feedrate in that case represent the flowrate/mm/s rpm of the tool. Reading around the correct way of setting the spindle speed or flowrate should be done using the gcode S command. Do you agree?
hzeller commented 8 years ago

Merged the test manually in https://github.com/hzeller/beagleg/commit/5294ce90bb9a2cd03a42d813cd0505561c38545b which works with the code in Pull request #17 . Is there more to pull out of here, or are we ready to close it ?

bigguiness commented 8 years ago

Should this be closed?

hzeller commented 8 years ago

Yes, this can be closed.