hzeller / beagleg

G-code interpreter and stepmotor controller for crazy fast coordinated moves of up to 8 steppers. Uses the Programmable Realtime Unit (PRU) of the Beaglebone.
http://beagleg.org/
GNU General Public License v3.0
122 stars 51 forks source link

moving the shadow queue into motor-operations #26

Closed lromor closed 6 years ago

hzeller commented 7 years ago

Ok, so let's see if we can get this review finally finished. Sorry for the delay, I was kindof distracted with some other project in-between (LDGraphy).

We still have this one open question of where to test the queue, but I think it is fine if we submit this now and then evolve it over time. I don't want to stand in the way of this getting submitted.

There are still the one or other smaller remark though, please have a look if these still need addressing.

Since we have in the meantime several submits, can you provide a good description that we can put on the final merged submit for this change that describes what we do here ? (like describing the separation of the various queues).

Unfortunately, my CNC machine is still in re-wiring mode, so I ask the folks on the mailing list to test the current patch.