search

hzeller / gmrender-resurrect

Resource efficient UPnP/DLNA renderer, optimal for Raspberry Pi, CuBox or a general MediaServer. Fork of GMediaRenderer to add some features to make it usable.
GNU General Public License v2.0
832 stars 202 forks source link

Resolves issue #100 (systemd script for debian/raspbian jessie) #111

Closed hu55a1n1 closed 7 years ago

hu55a1n1 commented 7 years ago

Hope I've placed the script in the right place.

hu55a1n1 commented 7 years ago

Sorry for the late reply. I was a little caught up with another project on my blog.

You're right about the fixed UUID. I'll fix this soon.

hu55a1n1 commented 7 years ago

Now, I'm doing it the same way you are, in the scripts/init.d/gmediarenderer init script. I just realised bash substitution isn't that straightforward in systemd unit files. :) But I managed to get this done somehow.

coldtobi commented 7 years ago

bash is usually quite heavy. Would it also work with standard /bin/sh?

hu55a1n1 commented 7 years ago

@coldtobi
I'm not really a shell guy, but I just tried on my ubuntu desktop and it seems to be working. 👍

hzeller commented 7 years ago

Thanks for the changes. I'll merge it today and replace the bash with sh.

Maybe I should make it easier to create a st able UUID from the ethernet interface already in gmrender resurrect, but unfortunately, that would be system dependent (I know something that would work on Linux but not necessarily on other Unixes; though I presume this is mostly used on Linux anyway, so not really a big deal).

hu55a1n1 commented 7 years ago

You're welcome. :) I just replaced bash with sh myself.

Maybe I should make it easier to create a st able UUID from the ethernet interface already in gmrender resurrect

That'll be great!

And thanks for gmrender-resurrect!

hzeller commented 7 years ago

Thanks! Just pushed as https://github.com/hzeller/gmrender-resurrect/commit/57dfbfd474f9008cc91f7a57b38ec4a7f96ae593