C++ Conversion - OuputModule class

hzeller / gmrender-resurrect

Resource efficient UPnP/DLNA renderer, optimal for Raspberry Pi, CuBox or a general MediaServer. Fork of GMediaRenderer to add some features to make it usable.

GNU General Public License v2.0

841 stars 204 forks source link

C++ Conversion - OuputModule class #194

Closed mill1000 closed 4 years ago

mill1000 commented 4 years ago

Re-implement output modules as C++ classes.

Main changes:

OutputModule is an abstract base class (interface) which actual output modules implement.
GstreamerOutput implements the OutputModule interface for Gstreamer (duh).
The Output namespace (maybe should be a static class?) abstracts the creation and use of the selected output module.

Additional impacts:

MIME type registration is much faster now as we not longer construct a GstElement for each GstFeature/Plugin
upnp_connmgr now requests supported MIME types from the output instead of getting them asynchronously.
MIME type filter abstracted into its own class.
Found some additional compatibility tweaks for upnp_compat.h when building against libupnp-1.6.24 on WSL Ubuntu
Some changes rippled through to the song_meta_data. I called dibs on converting that next :)

hzeller commented 4 years ago

Thanks, I'll try to have a look on the weekend, though I might be pretty busy (currently at Hackaday Superconference). So could be Monday or Tuesday.

mill1000 commented 4 years ago

@hzeller Any chance you could take a look at this sometime soon? I understand it's a busy time of year. Just hoping to keep things moving a little.

hzeller commented 4 years ago

Yes, sorry @mill1000 the last couple of weeks were indeed busy. Next week will be less stress, hopefully I can already have a look on Sunday.

hzeller commented 4 years ago

Ready to review ?

mill1000 commented 4 years ago

Yes I believe so

On Wed, Jan 15, 2020, 12:23 PM Henner Zeller notifications@github.com wrote:

Ready to review ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hzeller/gmrender-resurrect/pull/194?email_source=notifications&email_token=ABU2STRPCF7IMGEIJME52NTQ55PEXA5CNFSM4JIMJ3S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBP43Q#issuecomment-574815854, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABU2STR5OSTQHPV7ZYIL6ZDQ55PEXANCNFSM4JIMJ3SQ .

hzeller commented 4 years ago

Thanks Tucker, merged!

Sorry for the long review, but I suspect future reviews will be much faster.

mill1000 commented 4 years ago

Yes I believe it will. Thanks for your patience.