Removed gotos from output.c

hzeller / gmrender-resurrect

Resource efficient UPnP/DLNA renderer, optimal for Raspberry Pi, CuBox or a general MediaServer. Fork of GMediaRenderer to add some features to make it usable.

GNU General Public License v2.0

839 stars 204 forks source link

Removed gotos from output.c #21

Closed ghost closed 11 years ago

hzeller commented 11 years ago

I think you messed up some logic at the end of some functions; some actually do end with a failure.

hzeller commented 11 years ago

Hopefully, I didn't scare you away with my pedantic reviews. Any update on this one ?

ghost commented 11 years ago

Sorry. One of my brothers died from a heart attack. Life (or the lack thereof) took precedence.

hzeller commented 11 years ago

I am very sorry to hear. Being in a family that had similar sudden strikes of fate I feel with you deeply. I send you my sincere condolences and hugs and strength for this hard time ahead of you.

Don't worry about this review - I'll try to get merged and done whatever is left over.

ghost commented 11 years ago

Thanks. He left us with style. He's been a true Rock&Roll guy throughout his life. He died just minutes after the end of a rock concert. As I said. with style.

I deeply miss him, but can only smile when I think of it. And I believe that's what he wanted us to do.

Anyway, your reviews are good. Code review is good. Keep 'em coming.

hzeller commented 11 years ago

Thanks!

ghost commented 11 years ago

My pleasure.