search

hzeller / gmrender-resurrect

Resource efficient UPnP/DLNA renderer, optimal for Raspberry Pi, CuBox or a general MediaServer. Fork of GMediaRenderer to add some features to make it usable.
GNU General Public License v2.0
841 stars 204 forks source link

Audio seek subscription #252

Open vidicunt opened 2 years ago

vidicunt commented 2 years ago

Hello!

Subscribing to AVTransport does not notify when the user seeks the audio. How can I be notified of this?

mill1000 commented 2 years ago

Looks like the seek command is not switching the transport state to "TRANSITIONING" as required by the AVTransport spec. https://github.com/hzeller/gmrender-resurrect/blob/4ac7d8914dc089651ae9d6c421ecda8f4d0ab5e3/src/upnp_transport.c#L881-L887

image

This is similar to the seeking issues reported in #217, which are partially caused by the incorrect return type below which is fixed in PR #241 https://github.com/hzeller/gmrender-resurrect/blob/4ac7d8914dc089651ae9d6c421ecda8f4d0ab5e3/src/output_gstreamer.c#L198-L202

vidicunt commented 2 years ago

Thank you! I'll be waiting for the merge then

mill1000 commented 2 years ago

Might be worth keeping open since I don't think #241 will fully solve the seek eventing