hzeller / gmrender-resurrect

Resource efficient UPnP/DLNA renderer, optimal for Raspberry Pi, CuBox or a general MediaServer. Fork of GMediaRenderer to add some features to make it usable.
GNU General Public License v2.0
834 stars 202 forks source link

gmrender-resurrect crashes after reaching the end of the playlist #38

Closed hjheins closed 10 years ago

hjheins commented 10 years ago

Hi HZeller,

I found the following issue on Debian Wheezy on PC: gmrender-res seems to crash after it reached the end of the list of songs to play in the remote app. The error is:

ERROR [2013-09-05 21:46:13.485001 | gstreamer] setting play state failed (1)ERROR [2013-09-05 21:46:13.485016 | gstreamer] uridecodebin2: Error: Invalid URI "". (Debug: gsturidecodebin.c(1262): gen_source_element (): /GstPlayBin2:play/GstURIDecodeBin:uridecodebin2) ERROR [2013-09-05 21:46:13.485179 | gstreamer] setting play state failed (2) ERROR [2013-09-05 21:46:13.485198 | upnp] upnp_set_error: Playing failed ERROR [2013-09-05 21:46:13.485454 | gstreamer] uridecodebin2: Error: Invalid URI "". (Debug: gsturidecodebin.c(1262): gen_source_element (): /GstPlayBin2:play/GstURIDecodeBin:uridecodebin2)

what can I do to fix/prevent this?

best regards,

Hendrik-Jan

P.S. this is stock Wheezy, so gstreamer 0.10

hzeller commented 10 years ago

What is the controller app you're using ? It seems to send an empty URL at the end of the playlist, which is hardly the right way.

But anyway, you can work around this by looking at output_gstreamer.c and look at the functions output_gstreamer_set_uri() and output_gstreamer_set_next_uri(). They should check the strlen() of the URI and set the gs_nexturi and gsuri_ to NULL.

Please fork gmrender-resurrect and fix it in your local client; once it is working with your UPnP-controller, send me a pull request and I'll integrate it.

hjheins commented 10 years ago

Update: Just to be sure, I installed gstreamer 1.0 It seems this solves about all issues I saw.

SO this one can be closed.

For the record: the solution is to install gstreamer 1.0

hzeller commented 10 years ago

I still might want to add a work-around for people that are stuck on 0.10 for one reason or another. To be able to re-produce: what is the client controller software you're using ?

hjheins commented 10 years ago

Hi,

I was using eezpnp. Though I am not sure that this app is in any way a "standard" app to use. I us it just to simulate issues I see elsewhere so I can solve them. you cna find it here: http://www.eezupnp.de/

best regards,

Hendrik-Jan

hzeller commented 10 years ago

Danke, schaue ich mir mal an :)

hjheins commented 10 years ago

Danke dir für die schnelle Reaktion und die Arbeit an dieses super Applikation!

Hendrik-Jan