Updated for CentOS 7 build and install

hzeller / gmrender-resurrect

Resource efficient UPnP/DLNA renderer, optimal for Raspberry Pi, CuBox or a general MediaServer. Fork of GMediaRenderer to add some features to make it usable.

GNU General Public License v2.0

834 stars 202 forks source link

Updated for CentOS 7 build and install #72

Closed ghost closed 9 years ago

ghost commented 9 years ago

.spec file was reused from Fedora and updated ::
- creates system user + group gmediarender upon installation and add to group 'audio', also removes all on package uninstalltion, homedir is set to /usr/share/gmediarender/ so ownership is also updated
.service file was reused from Fedora and updated ::
- service runs as unpriviledged user 'gmediarender'

hzeller commented 9 years ago

Nice - thank you!

Ideally, CentOS and Fedora would use the same spec file (assuming the conventions of creating role-usernames etc. are similar in both). I don't know the conventions on both of these, and since you are working on CentOS, you might not know what is going on in Fedora.

But I suggest to add a README in both directories pointing to the other distribution *.spec files and give a rough overview of the difference - so that the next person modifying either of these is aware of the cross-link.

Other than that ... ready to merge...

ghost commented 9 years ago

It took longer than I originally intended, but I reviewed build process for both Fedora (I used 21 for tests) and CentOS 7. I've added brief README.md for both as you asked. And I've also modified .spec file for Fedora, not only 'fixed' mine for CentOS 7. Please, review the details.

hzeller commented 9 years ago

This looks good from my perspective (just looking at the changes; currently don't have any RPM based system to test).

I haven't merged it yet as I am currently traveling with not much computer time at hand, and I would like to squash your many commits into one, which cannot be done with the github frontend.

If you can provide me with a pull request with a single commit, I can merge it directly in github.

hzeller commented 9 years ago

Thanks, merged now.